Test: EC generateKeyPairSync invalid parameter encoding#27212
Closed
rpgeeganage wants to merge 1 commit intonodejs:masterfrom
Closed
Test: EC generateKeyPairSync invalid parameter encoding#27212rpgeeganage wants to merge 1 commit intonodejs:masterfrom
rpgeeganage wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
Author
|
Sorry that, I had to close the PR #27200. |
rpgeeganage
changed the title
Member
|
@rpgeeganage Can you rebase the old PR against master and force-push to that branch, then reopen the PR? Opening a new PR is inconvenient because the old one already had two sign-offs. |
Contributor
Author
|
@richardlau @bnoordhuis , |
bnoordhuis
approved these changes
Apr 13, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Okay, no problem. The change itself still LGTM. :-)
Collaborator
richardlau
approved these changes
Apr 14, 2019
ZYSzys
added
the
author ready
BridgeAR
approved these changes
Apr 16, 2019
Contributor
|
Landed in de463f1 🎉 |
danbev
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #27212 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes